Added voting, weighting methods, fixed LeaveOneOutNoDistance, and added cross-validation for KNN #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m-patch-2 Add files via upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LOOND now passes on the parameters from the GUI to the analysisDriver. Added a weighted voting algorithm to combine other Analysis Drivers and put them to a vote, and implemented two weighting options. Finally, implemented cross-validation for KNN.
TODO: Implement more weighting and voting options.
Edit: Changed API to exclude the relevant known document from the training set for cross-validation.