Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2751 - Csv reading - cells filled with spaces only are converted to 0 #2752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tlgman
Copy link

@tlgman tlgman commented Apr 23, 2024

Summary

Fix #2751

Test plan

const wb = new ExcelJS.Workbook();
wb.csv.read(Stream.Readable.from('firstValue;    ;secondValue', { parserOptions: { delimiter: ';' } })
const ws = wb.worksheets[templateInfo.worksheet];

const row1 = ws.getRow(1);
const cell12 = row1.getCell(2);
console.log('cell: 1,2: ', cell12.value); // Displays:  '    ' 

Related to source code (for typings update)

(https://github.com/exceljs/exceljs/blob/master/lib/csv/csv.js#L58)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Csv reading - cells filled with spaces only are converted to 0
2 participants