Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification about new comment, but there is none #2964

Closed
NobbZ opened this issue Jul 1, 2016 · 11 comments
Closed

Notification about new comment, but there is none #2964

NobbZ opened this issue Jul 1, 2016 · 11 comments

Comments

@NobbZ
Copy link
Member

NobbZ commented Jul 1, 2016

no_comment

This is not the first time this happened, but the first time I was able to do some screenshot. This has happend about 4 or 5 times during the last 6 months, so the rate is very low.

To summarize the picture shown above:

There has been a notification about a comment to one of my submissions, after opening that submission there are no (new) comments on any given iteration (there is only one iteratation without comments in this example).

After following that link in the notification to my submission, the notification is marked as read and vanishes.

@kytrinyx
Copy link
Member

kytrinyx commented Jul 1, 2016

I'm pretty sure this is when people comment and then delete their comment. I don't think we currently track the comment id in notifications, so deleting the notification is probably not super trivial.

@NobbZ
Copy link
Member Author

NobbZ commented Jul 1, 2016

One can delete a comment? I never realized...

@kotp
Copy link
Member

kotp commented Jul 1, 2016

The delete is when you click on 'edit'. You can't "cancel" an edit, just browse away from it, effectively doing the "cancel". The options are "delete" and "submit".

@kytrinyx
Copy link
Member

kytrinyx commented Jul 1, 2016

Yeah, the UX is not great on this. I've been hoping a designer would like to help rethink the whole page for a better usability.

@MohanL
Copy link

MohanL commented Oct 20, 2016

Would it be great if the system has a retract feature for the notifications like invitations, comments ?

potentially relate to #3185

@c1505, what is your idea about this issue, since you are working on retracting the invitations. they are kind of similar.

@c1505
Copy link

c1505 commented Oct 21, 2016

@MohanL I haven't had much time to look over #3185 yet this week. Haven't looked at the implementation of notifications yet. Targeting this weekend to submit the PR.

An alternative solution could be to also notify when a comment is deleted. Not sure which would be more appropriate here.

@kytrinyx
Copy link
Member

What if we marked comments as deleted and instead of showing the comment, we showed a message in the comment flow saying something like @username deleted their comment?

@MohanL
Copy link

MohanL commented Oct 23, 2016

@kytrinyx in my opinion, I still feel like we should not bother people by the unnecessary notifications. For people who have obsessive-compulsive disorder about notifications, it is a pain.

@MohanL
Copy link

MohanL commented Oct 23, 2016

@kytrinyx
I think @username deleted their comment is a great idea, but do we need the notifications though ?

@kytrinyx
Copy link
Member

@MohanL No, we don't need a notification, I just don't know if we can delete it at the moment.

@kytrinyx
Copy link
Member

We're going to need to reconsider the data model for this one when we rethink the notifications.

I've added the design research label to this so that we can evaluate the question within the larger context of the design reboot (see exercism/discussions#113 for more about this).

Since this issue addresses things that are going to be difficult to implement as a quick experiment in the current prototype, I'm going to close this. If you do think that it can be implemented as a not-too jarring and not-too complicated experiment in the current website, please open a new issue about it in the discussions repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants