Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add Assets guide to Home #28331

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

amandeepmittal
Copy link
Member

@amandeepmittal amandeepmittal commented Apr 19, 2024

Why

Follow up #28261

How

  • Update the outdated Assets guide

  • Add it to Home > Develop > User Interface

  • Add info on how to load local assets using expo-assets config plugin
    Capture-2024-04-19-231949

  • Remove duplicated info on optimizing images manually from Expo Updates Assets guide and update the section in Assets guide since this guide comes first in the hierarchy

Capture-2024-04-19-232208

  • Update Fonts guide to add a section on initial loading expo/vector-icons package

Capture-2024-04-19-232244

  • Update navigation.js file and add redirects for the new URL

Test Plan

Run docs locally and visit: http://localhost:3002/develop/user-interface/assets/, or see Preview: http://docs.expo.dev-pr-28331.s3-website-us-east-1.amazonaws.com/develop/user-interface/assets/

Checklist

@expo-bot expo-bot added the bot: passed checks ExpoBot has nothing to complain about label Apr 19, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Apr 19, 2024

📘 Your docs preview website is ready!

Copy link
Member

@jonsamp jonsamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loved the assets docs and learned some things! Left some comments on things i would change. Thanks for writing this up.

docs/pages/develop/user-interface/assets.mdx Outdated Show resolved Hide resolved
docs/pages/develop/user-interface/assets.mdx Outdated Show resolved Hide resolved
docs/pages/develop/user-interface/assets.mdx Outdated Show resolved Hide resolved
docs/pages/develop/user-interface/assets.mdx Outdated Show resolved Hide resolved
docs/pages/develop/user-interface/fonts.mdx Outdated Show resolved Hide resolved
docs/pages/develop/user-interface/fonts.mdx Outdated Show resolved Hide resolved
docs/pages/develop/user-interface/fonts.mdx Outdated Show resolved Hide resolved
docs/pages/develop/user-interface/fonts.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants