[expo-linear-gradient] Make colors and locations arrays readonly #28450

kowczarz · 2024-04-25T10:45:20Z

Why

This change allows users to pass readonly arrays as props without redundantly copying it before.

Changed colors and locations types to readonly.

Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
Conforms with the Documentation Writing Style Guide
This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).

lukmccall

LGTM ✅

packages/expo-linear-gradient/CHANGELOG.md

Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>

Make colors and locations arrays readonly

69ce5c1

expo-bot added the bot: suggestions ExpoBot has some suggestions label Apr 25, 2024

kowczarz added 2 commits April 25, 2024 12:47

Update CHANGELOG.md

ba50f3f

Update comments

cebca06

expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Apr 25, 2024

kowczarz force-pushed the make-colors-and-locations-arrays-readonly branch from 9a5f18c to cebca06 Compare April 25, 2024 10:51

kowczarz marked this pull request as ready for review April 25, 2024 10:55

kowczarz requested a review from alanjhughes as a code owner April 25, 2024 10:55

Fix lint

eaa7e5f

lukmccall requested review from aleqsio and lukmccall April 25, 2024 11:34

lukmccall approved these changes Apr 25, 2024

View reviewed changes

packages/expo-linear-gradient/CHANGELOG.md Show resolved Hide resolved

Apply review suggestions

b218275

Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>

lukmccall merged commit 8ecdde5 into expo:main Apr 30, 2024
10 checks passed

brentvatne added the published Changes from the PR have been published to npm label May 1, 2024