Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional targets field #28478

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented Apr 26, 2024

Why

#27796 (comment)

How

Test Plan

Checklist

@sbrighiu
Copy link

"expo": "expo/expo#ccead8b",
->
Performing "GET" request to "https://codeload.github.com/expo/expo/tar.gz/ccead8b09d2741b8fce904bc296f70a8c3791fa2". takes forever :) @aleqsio

@aleqsio
Copy link
Contributor Author

aleqsio commented Apr 26, 2024

@sbrighiu I know 😅 It's 40+gb :)

Maybe you can try to patch-package and just copy the js file over?

@sbrighiu
Copy link

yeah :)

rm -rf ./ios && rm -rf ./android && npx expo prebuild --clean Need to install the following packages: expo@50.0.17 Ok to proceed? (y) npm ERR! canceled

@aleqsio
Copy link
Contributor Author

aleqsio commented Apr 26, 2024

I see that some tests are failing – let me take a look.

@sbrighiu
Copy link

sbrighiu commented Apr 26, 2024

I applied the below patch... expo++@expo+config-plugins+7.9.1.patch

expo++@expo+config-plugins+7.9.1.patch

It did not seem to work

@aleqsio
Copy link
Contributor Author

aleqsio commented Apr 26, 2024

@sbrighiu How do you add an additional target to expo prebuild? Trying to figure out how to test this.

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 0aea1f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants