Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scroll in commit message box #1415

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

heiskane
Copy link
Contributor

It changes the following:

  • Scrolls the text in the commit message box

As discussed in #1333 this implements a scroll in commit message box.

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Owner

@heiskane how is it going - need support? feel free to join the discord 👍

@heiskane
Copy link
Contributor Author

@heiskane how is it going - need support? feel free to join the discord 👍

I got the scroll mostly working but for some reason you can add unlimited amount of spaces without it wrapping to the next line. I think that should be the last problem to solve to get it working but I haven't looked at it too closely yet. As a side note I would like to add a zero width space before the cursor break it from the actual word for proper wrapping but the tui crate is not handling it correctly.

@extrawurst
Copy link
Owner

@heiskane are you still on this?

@heiskane
Copy link
Contributor Author

heiskane commented Jan 5, 2023

@extrawurst I have been a bit busy and haven't really been able to make progress on this one. I do want to keep working on this but am unsure if i have the time right now.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the dormant Marked by stale bot on close label Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dormant Marked by stale bot on close
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants