Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for external ssh signing #2198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add support for external ssh signing #2198

wants to merge 1 commit into from

Conversation

seanaye
Copy link

@seanaye seanaye commented Apr 19, 2024 •
edited

TODO

  • add tests

This Pull Request fixes/closes #2188.

It changes the following:

  • Adds support for external bin signing with ssh keys

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Owner

@yanganto you are the most prominent user of ssh-signing. can you review this?

@extrawurst extrawurst assigned extrawurst and unassigned extrawurst Apr 21, 2024
@extrawurst
Copy link
Owner

@seanaye is there a way to write a test for this?

@seanaye
Copy link
Author

seanaye commented Apr 29, 2024

I'll try to write some tests this week

@kucho
Copy link

kucho commented Apr 29, 2024

Very excited about this feature to start using gitui as my daily driver! Thank you, @seanaye 🙏

@b1nhack
Copy link

b1nhack commented May 8, 2024

Thanks a lot, I'm waiting for this feature.

@b1nhack b1nhack mentioned this pull request May 17, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ssh signing] support custom signing program
4 participants
@seanaye @extrawurst @kucho @b1nhack