[FixturesBundle] Introduce scalar types

src/Sylius/Bundle/FixturesBundle/Command/FixturesListCommand.php

@@ -27,7 +27,7 @@ final class FixturesListCommand extends ContainerAwareCommand
     /**
      * {@inheritdoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('sylius:fixtures:list')
@@ -38,7 +38,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): void
     {
         $this->listSuites($output);
         $this->listFixtures($output);
@@ -47,7 +47,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
     /**
      * @param OutputInterface $output
      */
-    private function listSuites(OutputInterface $output)
+    private function listSuites(OutputInterface $output): void
     {
         $suites = $this->getSuiteRegistry()->getSuites();
 
@@ -61,7 +61,7 @@ private function listSuites(OutputInterface $output)
     /**
      * @param OutputInterface $output
      */
-    private function listFixtures(OutputInterface $output)
+    private function listFixtures(OutputInterface $output): void
     {
         $fixtures = $this->getFixtureRegistry()->getFixtures();
 
@@ -75,15 +75,15 @@ private function listFixtures(OutputInterface $output)
     /**
      * @return SuiteRegistryInterface
      */
-    private function getSuiteRegistry()
+    private function getSuiteRegistry(): SuiteRegistryInterface
     {
         return $this->getContainer()->get('sylius_fixtures.suite_registry');
     }
 
     /**
      * @return FixtureRegistryInterface
      */
-    private function getFixtureRegistry()
+    private function getFixtureRegistry(): FixtureRegistryInterface
     {
         return $this->getContainer()->get('sylius_fixtures.fixture_registry');
     }

src/Sylius/Bundle/FixturesBundle/Command/FixturesLoadCommand.php

@@ -32,7 +32,7 @@ final class FixturesLoadCommand extends ContainerAwareCommand
     /**
      * {@inheritdoc}
      */
-    protected function configure()
+    protected function configure(): void
     {
         $this
             ->setName('sylius:fixtures:load')
@@ -44,7 +44,7 @@ protected function configure()
     /**
      * {@inheritdoc}
      */
-    protected function execute(InputInterface $input, OutputInterface $output)
+    protected function execute(InputInterface $input, OutputInterface $output): void
     {
         if ($input->isInteractive()) {
             /** @var QuestionHelper $questionHelper */
@@ -66,7 +66,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
     /**
      * @param InputInterface $input
      */
-    private function loadSuites(InputInterface $input)
+    private function loadSuites(InputInterface $input): void
     {
         $suiteName = $input->getArgument('suite');
         $suite = $this->getSuiteRegistry()->getSuite($suiteName);
@@ -77,15 +77,15 @@ private function loadSuites(InputInterface $input)
     /**
      * @return SuiteRegistryInterface
      */
-    private function getSuiteRegistry()
+    private function getSuiteRegistry(): SuiteRegistryInterface
     {
         return $this->getContainer()->get('sylius_fixtures.suite_registry');
     }
 
     /**
      * @return SuiteLoaderInterface
      */
-    private function getSuiteLoader()
+    private function getSuiteLoader(): SuiteLoaderInterface
     {
         return $this->getContainer()->get('sylius_fixtures.suite_loader');
     }

src/Sylius/Bundle/FixturesBundle/DependencyInjection/Compiler/FixtureRegistryPass.php

@@ -26,7 +26,7 @@ final class FixtureRegistryPass implements CompilerPassInterface
     /**
      * {@inheritdoc}
      */
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         if (!$container->has('sylius_fixtures.fixture_registry')) {
             return;

src/Sylius/Bundle/FixturesBundle/DependencyInjection/Compiler/ListenerRegistryPass.php

@@ -26,7 +26,7 @@ final class ListenerRegistryPass implements CompilerPassInterface
     /**
      * {@inheritdoc}
      */
-    public function process(ContainerBuilder $container)
+    public function process(ContainerBuilder $container): void
     {
         if (!$container->has('sylius_fixtures.listener_registry')) {
             return;

src/Sylius/Bundle/FixturesBundle/DependencyInjection/Configuration.php

@@ -25,7 +25,7 @@ final class Configuration implements ConfigurationInterface
     /**
      * {@inheritdoc}
      */
-    public function getConfigTreeBuilder()
+    public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder();
         $rootNode = $treeBuilder->root('sylius_fixtures');
@@ -38,7 +38,7 @@ public function getConfigTreeBuilder()
     /**
      * @param ArrayNodeDefinition $rootNode
      */
-    private function buildSuitesNode(ArrayNodeDefinition $rootNode)
+    private function buildSuitesNode(ArrayNodeDefinition $rootNode): void
     {
         /** @var ArrayNodeDefinition $suitesNode */
         $suitesNode = $rootNode
@@ -73,7 +73,7 @@ private function buildSuitesNode(ArrayNodeDefinition $rootNode)
     /**
      * @param ArrayNodeDefinition $suitesNode
      */
-    private function buildFixturesNode(ArrayNodeDefinition $suitesNode)
+    private function buildFixturesNode(ArrayNodeDefinition $suitesNode): void
     {
         /** @var ArrayNodeDefinition $fixturesNode */
         $fixturesNode = $suitesNode
@@ -91,7 +91,7 @@ private function buildFixturesNode(ArrayNodeDefinition $suitesNode)
     /**
      * @param ArrayNodeDefinition $suitesNode
      */
-    private function buildListenersNode(ArrayNodeDefinition $suitesNode)
+    private function buildListenersNode(ArrayNodeDefinition $suitesNode): void
     {
         /** @var ArrayNodeDefinition $listenersNode */
         $listenersNode = $suitesNode
@@ -107,7 +107,7 @@ private function buildListenersNode(ArrayNodeDefinition $suitesNode)
     /**
      * @param ArrayNodeDefinition $node
      */
-    private function buildAttributesNode(ArrayNodeDefinition $node)
+    private function buildAttributesNode(ArrayNodeDefinition $node): void
     {
         $attributesNodeBuilder = $node->canBeUnset()->children();
         $attributesNodeBuilder->integerNode('priority')->defaultValue(0);

src/Sylius/Bundle/FixturesBundle/DependencyInjection/SyliusFixturesExtension.php

@@ -27,7 +27,7 @@ final class SyliusFixturesExtension extends Extension implements PrependExtensio
     /**
      * {@inheritdoc}
      */
-    public function load(array $config, ContainerBuilder $container)
+    public function load(array $config, ContainerBuilder $container): void
     {
         $config = $this->processConfiguration($this->getConfiguration([], $container), $config);
         $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
@@ -40,7 +40,7 @@ public function load(array $config, ContainerBuilder $container)
     /**
      * {@inheritdoc}
      */
-    public function prepend(ContainerBuilder $container)
+    public function prepend(ContainerBuilder $container): void
     {
         $loader = new XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
 
@@ -63,7 +63,7 @@ public function prepend(ContainerBuilder $container)
      * @param array $config
      * @param ContainerBuilder $container
      */
-    private function registerSuites(array $config, ContainerBuilder $container)
+    private function registerSuites(array $config, ContainerBuilder $container): void
     {
         $suiteRegistry = $container->findDefinition('sylius_fixtures.suite_registry');
         foreach ($config['suites'] as $suiteName => $suiteConfiguration) {

src/Sylius/Bundle/FixturesBundle/Fixture/AbstractFixture.php

@@ -24,7 +24,7 @@ abstract class AbstractFixture implements FixtureInterface
     /**
      * {@inheritdoc}
      */
-    final public function getConfigTreeBuilder()
+    final public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder();
         $optionsNode = $treeBuilder->root($this->getName());
@@ -37,7 +37,7 @@ final public function getConfigTreeBuilder()
     /**
      * @param ArrayNodeDefinition $optionsNode
      */
-    protected function configureOptionsNode(ArrayNodeDefinition $optionsNode)
+    protected function configureOptionsNode(ArrayNodeDefinition $optionsNode): void
     {
         // empty
     }

src/Sylius/Bundle/FixturesBundle/Fixture/FixtureInterface.php

@@ -23,10 +23,10 @@ interface FixtureInterface extends ConfigurationInterface
     /**
      * @param array $options
      */
-    public function load(array $options);
+    public function load(array $options): void;
 
     /**
      * @return string
      */
-    public function getName();
+    public function getName(): string;
 }

src/Sylius/Bundle/FixturesBundle/Fixture/FixtureNotFoundException.php

@@ -22,7 +22,7 @@ final class FixtureNotFoundException extends \InvalidArgumentException
      * @param string $name
      * @param \Exception|null $previous
      */
-    public function __construct($name, \Exception $previous = null)
+    public function __construct(string $name, ?\Exception $previous = null)
     {
         parent::__construct(sprintf('Fixture with name "%s" could not be found!', $name), 0, $previous);
     }

src/Sylius/Bundle/FixturesBundle/Fixture/FixtureRegistry.php

@@ -28,7 +28,7 @@ final class FixtureRegistry implements FixtureRegistryInterface
     /**
      * @param FixtureInterface $fixture
      */
-    public function addFixture(FixtureInterface $fixture)
+    public function addFixture(FixtureInterface $fixture): void
     {
         Assert::keyNotExists($this->fixtures, $fixture->getName(), 'Fixture with name "%s" is already registered.');
 
@@ -38,7 +38,7 @@ public function addFixture(FixtureInterface $fixture)
     /**
      * {@inheritdoc}
      */
-    public function getFixture($name)
+    public function getFixture(string $name): FixtureInterface
     {
         if (!isset($this->fixtures[$name])) {
             throw new FixtureNotFoundException($name);
@@ -50,7 +50,7 @@ public function getFixture($name)
     /**
      * {@inheritdoc}
      */
-    public function getFixtures()
+    public function getFixtures(): array
     {
         return $this->fixtures;
     }

src/Sylius/Bundle/FixturesBundle/Fixture/FixtureRegistryInterface.php

@@ -25,10 +25,10 @@ interface FixtureRegistryInterface
      *
      * @throws FixtureNotFoundException
      */
-    public function getFixture($name);
+    public function getFixture(string $name): FixtureInterface;
 
     /**
-     * @return FixtureInterface[] Name indexed
+     * @return array|FixtureInterface[] Name indexed
      */
-    public function getFixtures();
+    public function getFixtures(): array;
 }

src/Sylius/Bundle/FixturesBundle/Listener/AbstractListener.php

@@ -24,7 +24,7 @@ abstract class AbstractListener implements ListenerInterface
     /**
      * {@inheritdoc}
      */
-    final public function getConfigTreeBuilder()
+    final public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder();
         $optionsNode = $treeBuilder->root($this->getName());
@@ -37,7 +37,7 @@ final public function getConfigTreeBuilder()
     /**
      * @param ArrayNodeDefinition $optionsNode
      */
-    protected function configureOptionsNode(ArrayNodeDefinition $optionsNode)
+    protected function configureOptionsNode(ArrayNodeDefinition $optionsNode): void
     {
         // empty
     }

src/Sylius/Bundle/FixturesBundle/Listener/AfterFixtureListenerInterface.php

@@ -22,5 +22,5 @@ interface AfterFixtureListenerInterface extends ListenerInterface
      * @param FixtureEvent $fixtureEvent
      * @param array $options
      */
-    public function afterFixture(FixtureEvent $fixtureEvent, array $options);
+    public function afterFixture(FixtureEvent $fixtureEvent, array $options): void;
 }

src/Sylius/Bundle/FixturesBundle/Listener/AfterSuiteListenerInterface.php

@@ -22,5 +22,5 @@ interface AfterSuiteListenerInterface extends ListenerInterface
      * @param SuiteEvent $suiteEvent
      * @param array $options
      */
-    public function afterSuite(SuiteEvent $suiteEvent, array $options);
+    public function afterSuite(SuiteEvent $suiteEvent, array $options): void;
 }

src/Sylius/Bundle/FixturesBundle/Listener/BeforeFixtureListenerInterface.php

@@ -22,5 +22,5 @@ interface BeforeFixtureListenerInterface extends ListenerInterface
      * @param FixtureEvent $fixtureEvent
      * @param array $options
      */
-    public function beforeFixture(FixtureEvent $fixtureEvent, array $options);
+    public function beforeFixture(FixtureEvent $fixtureEvent, array $options): void;
 }

src/Sylius/Bundle/FixturesBundle/Listener/BeforeSuiteListenerInterface.php

@@ -22,5 +22,5 @@ interface BeforeSuiteListenerInterface extends ListenerInterface
      * @param SuiteEvent $suiteEvent
      * @param array $options
      */
-    public function beforeSuite(SuiteEvent $suiteEvent, array $options);
+    public function beforeSuite(SuiteEvent $suiteEvent, array $options): void;
 }

src/Sylius/Bundle/FixturesBundle/Listener/FixtureEvent.php

@@ -51,23 +51,23 @@ public function __construct(SuiteInterface $suite, FixtureInterface $fixture, ar
     /**
      * @return SuiteInterface
      */
-    public function suite()
+    public function suite(): SuiteInterface
     {
         return $this->suite;
     }
 
     /**
      * @return FixtureInterface
      */
-    public function fixture()
+    public function fixture(): FixtureInterface
     {
         return $this->fixture;
     }
 
     /**
      * @return array
      */
-    public function fixtureOptions()
+    public function fixtureOptions(): array
     {
         return $this->fixtureOptions;
     }

src/Sylius/Bundle/FixturesBundle/Listener/ListenerInterface.php

@@ -23,5 +23,5 @@ interface ListenerInterface extends ConfigurationInterface
     /**
      * @return string
      */
-    public function getName();
+    public function getName(): string;
 }

src/Sylius/Bundle/FixturesBundle/Listener/ListenerNotFoundException.php

@@ -22,7 +22,7 @@ final class ListenerNotFoundException extends \InvalidArgumentException
      * @param string $name
      * @param \Exception|null $previous
      */
-    public function __construct($name, \Exception $previous = null)
+    public function __construct(string $name, ?\Exception $previous = null)
     {
         parent::__construct(sprintf('Listener with name "%s" could not be found!', $name), 0, $previous);
     }

src/Sylius/Bundle/FixturesBundle/Listener/ListenerRegistry.php

@@ -28,7 +28,7 @@ final class ListenerRegistry implements ListenerRegistryInterface
     /**
      * @param ListenerInterface $listener
      */
-    public function addListener(ListenerInterface $listener)
+    public function addListener(ListenerInterface $listener): void
     {
         Assert::keyNotExists($this->listeners, $listener->getName(), 'Listener with name "%s" is already registered.');
 
@@ -38,7 +38,7 @@ public function addListener(ListenerInterface $listener)
     /**
      * {@inheritdoc}
      */
-    public function getListener($name)
+    public function getListener(string $name): ListenerInterface
     {
         if (!isset($this->listeners[$name])) {
             throw new ListenerNotFoundException($name);
@@ -50,7 +50,7 @@ public function getListener($name)
     /**
      * {@inheritdoc}
      */
-    public function getListeners()
+    public function getListeners(): array
     {
         return $this->listeners;
     }

src/Sylius/Bundle/FixturesBundle/Listener/ListenerRegistryInterface.php

@@ -25,10 +25,10 @@ interface ListenerRegistryInterface
      *
      * @throws ListenerNotFoundException
      */
-    public function getListener($name);
+    public function getListener(string $name): ListenerInterface;
 
     /**
-     * @return ListenerInterface[] Name indexed
+     * @return array|ListenerInterface[] Name indexed
      */
-    public function getListeners();
+    public function getListeners(): array;
 }