Skip to content

Commit

Permalink
fixed twi implode() calls (wrong parameter order)
Browse files Browse the repository at this point in the history
implode() wants to have $glue first, then $pieces: http://php.net/implode

The note on that page says:
implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.

 So it was not really a bug, only a bit ugly :-)
  • Loading branch information
PHPGangsta committed Mar 7, 2018
1 parent 5205b2c commit 018171f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/transports/imap/imap_transport.php
Expand Up @@ -1089,7 +1089,7 @@ public function fetchSizes( $messages )
}

$sizes = array();
$ids = implode( $messages, ',' );
$ids = implode( ',', $messages );

$tag = $this->getNextTag();
$this->connection->sendData( "{$tag} {$uid}FETCH {$ids} (RFC822.SIZE)" );
Expand Down Expand Up @@ -2035,7 +2035,7 @@ public function fetchFlags( $messages )
}

$flags = array();
$ids = implode( $messages, ',' );
$ids = implode( ',', $messages );

$tag = $this->getNextTag();
$this->connection->sendData( "{$tag} {$uid}FETCH {$ids} (FLAGS)" );
Expand Down

0 comments on commit 018171f

Please sign in to comment.