Skip to content

Commit

Permalink
EZP-28926: Add validation for PermissionResolver::hasAccess(module, f…
Browse files Browse the repository at this point in the history
…unction) arguments (#2273)

* [WIP][6.7] Add validation for hasAccess(module, function) arguments

To avoid issues such as ezsystems/ezplatform-admin-ui#358

Todo:
- Find a way to move `eZ/Bundle/EzPublishCoreBundle/Resources/config/policies.yml` into core
  and reuse across Core and CoreBundle to get rid of the internal hard coded policy map.
- Unit tests, some failing with `Argument 'module' is invalid: 'module: test-module/ function: test-function' is wrong value`

* EZP-28926: Add validation for PermissionResolver::hasAccess(module, function) arguments

* CS fix

* Added missing empty line

* Updated specification

* Added deprecated info

* fixup! Added missing empty line

* Improved test code quality
  • Loading branch information
kmadejski authored and andrerom committed Mar 12, 2018
1 parent 8d1eeea commit 47419b8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions Tests/FieldType/BaseIntegrationTest.php
Expand Up @@ -584,6 +584,7 @@ protected function getContainer()
$loader->load('fieldtype_services.yml');
$loader->load('utils.yml');
$loader->load('tests/common.yml');
$loader->load('policies.yml');

$containerBuilder->setParameter('ezpublish.kernel.root_dir', $installDir);

Expand Down
1 change: 1 addition & 0 deletions Tests/FieldType/FileBaseIntegrationTest.php
Expand Up @@ -147,6 +147,7 @@ protected function getContainer()
$loader->load('fieldtype_services.yml');
$loader->load('utils.yml');
$loader->load('tests/common.yml');
$loader->load('policies.yml');

$containerBuilder->setParameter('ezpublish.kernel.root_dir', $installDir);

Expand Down

0 comments on commit 47419b8

Please sign in to comment.