Skip to content

Commit

Permalink
EZP-28649: Invalid field type label in content translation (ezsystems…
Browse files Browse the repository at this point in the history
  • Loading branch information
webhdx authored and Łukasz Serwatka committed Dec 21, 2017
1 parent 6ff90e8 commit 8f358e5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
4 changes: 3 additions & 1 deletion lib/FieldType/Mapper/KeywordFormMapper.php
Expand Up @@ -23,6 +23,8 @@ public function mapFieldValueForm(FormInterface $fieldForm, FieldData $data)
{
$fieldDefinition = $data->fieldDefinition;
$formConfig = $fieldForm->getConfig();
$names = $fieldDefinition->getNames();
$label = $fieldDefinition->getName($formConfig->getOption('mainLanguageCode')) ?: reset($names);

$fieldForm
->add(
Expand All @@ -32,7 +34,7 @@ public function mapFieldValueForm(FormInterface $fieldForm, FieldData $data)
KeywordFieldType::class,
[
'required' => $fieldDefinition->isRequired,
'label' => $fieldDefinition->getName($formConfig->getOption('languageCode')),
'label' => $label,
]
)
->setAutoInitialize(false)
Expand Down
2 changes: 1 addition & 1 deletion lib/FieldType/Mapper/RelationListFormMapper.php
Expand Up @@ -59,7 +59,7 @@ public function mapFieldValueForm(FormInterface $fieldForm, FieldData $data)
RelationListFieldType::class,
[
'required' => $fieldDefinition->isRequired,
'label' => $fieldDefinition->getName($label),
'label' => $label,
]
)
->setAutoInitialize(false)
Expand Down
4 changes: 3 additions & 1 deletion lib/FieldType/Mapper/TextLineFormMapper.php
Expand Up @@ -54,6 +54,8 @@ public function mapFieldValueForm(FormInterface $fieldForm, FieldData $data)
$fieldDefinition = $data->fieldDefinition;
$formConfig = $fieldForm->getConfig();
$validatorConfiguration = $fieldDefinition->getValidatorConfiguration();
$names = $fieldDefinition->getNames();
$label = $fieldDefinition->getName($formConfig->getOption('mainLanguageCode')) ?: reset($names);

$fieldForm
->add(
Expand All @@ -63,7 +65,7 @@ public function mapFieldValueForm(FormInterface $fieldForm, FieldData $data)
TextLineFieldType::class,
[
'required' => $fieldDefinition->isRequired,
'label' => $fieldDefinition->getName($formConfig->getOption('languageCode')),
'label' => $label,
'min' => $validatorConfiguration['StringLengthValidator']['minStringLength'],
'max' => $validatorConfiguration['StringLengthValidator']['maxStringLength'],
]
Expand Down

0 comments on commit 8f358e5

Please sign in to comment.