Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up EZP-29144: Handle missing LocationID and semanticPathInfo #160

Merged
merged 1 commit into from Oct 4, 2018

Conversation

kmadejski
Copy link
Member

@kmadejski kmadejski commented Oct 4, 2018

Question Answer
JIRA issue EZP-29144
Bug/Improvement yes
New feature no
Target version 1.4
BC breaks no
Doc needed yes (?)

This PR is a followup for #152. Since parameters passed to render_esi needs to be serializable, and in some cases null is passed there, it ends with the exception in application logs:

request.CRITICAL: Uncaught PHP Exception RuntimeException: "Controller "eZ\Bundle\EzPublishLegacyBundle\Controller\WebsiteToolbarController::websiteToolbarAction()" requires that you provide a value for the "$locationId" argument (because there is no default value or because there is a non optional argument after this one)." at [...path deleted...]\ezpublish\cache\prod\classes.php line 2233 {"exception":"[object] (RuntimeException(code: 0): Controller \"eZ\\Bundle\\EzPublishLegacyBundle\\Controller\\WebsiteToolbarController::websiteToolbarAction()\" requires that you provide a value for the \"$locationId\" argument (because there is no default value or because there is a non optional argument after this one). at [...path deleted...]\\ezpublish\\cache\\prod\\classes.php:2233)"} []

This PR introduces new default value for $locationId controller arguments and new additional argument, which is necessary for using WebsiteToolbar through render_esi.

Relevant PR on DemoBundle can be found here: ezsystems/DemoBundle#195

@andrerom andrerom merged commit c729019 into 1.4 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants