EZP-30170: [2.5LTS] Drop Varnish 4 + get rid of duplicated VCL in meta repo

[andrerom]

Story: https://jira.ez.no/browse/EZP-30170

Additional awareness / review ping:

• @vidarl Demo Cloud / Platform.sh impact?
• @Plopix eZ Launchpad impact?

Todo:

• Look into docker failure for behat

[andrerom]

@Plopix Will this change be a problem form eZ Launchpad? (aka do you need VCL file before composer install / create-project has been run)

@alongosz / @mnocon Same question for you, would it make sense to change setup_ezplatform.sh back to somehow run composer install before spinning up all containers?
And before you answer that, be aware we expect just that in solr contianer already: https://github.com/ezsystems/ezplatform/blob/master/doc/docker/Dockerfile-solr#L4 ;)

[mnocon]

Sadly I don't see any other clean way, given that the file is in another repository.

[Plopix]

@andrerom no, there is no impact for eZ Launchad as it has its own varnish.vcl which is bad actually if we want to maintain it globally in http cache bundle.

I will try to look into it, to remove this, actually, varnish is container is installed in the second round of docker-compose then it might be really simple.

[vidarl]

Should be no problem for Demo Cloud / Platform.sh.

And since we run composer install before the varnish container is builded, there should be no issues getting the .vcl from vendor/

[alongosz]

@alongosz / @mnocon Same question for you, would it make sense to change setup_ezplatform.sh back to somehow run composer install before spinning up all containers?
And before you answer that, be aware we expect just that in solr contianer already: https://github.com/ezsystems/ezplatform/blob/master/doc/docker/Dockerfile-solr#L4 ;)

When/where exactly is this Dockerfile used? Maybe we could split the process into app (where composer install happens) + others after? composer install was moved to be done inside app container because of a couple of reasons:

• it sets proper permissions for environment inside docker container
• it executes composer taking into account docker environment (this might be of no impact if Travis Trusty env is in sync with what docker container offers, but might lead to problems in the future).

I'm not in the loop when it comes to the actual issue, but if this is related to eZ Launchpad, then maybe it calls for a separate setup script? setup_ezplatform.sh is done to support Travis CI only.

[andrerom]

Maybe we could split the process into app (where composer install happens) + others after?

This is what it did before (first do a build stage to pull in packages). This is also what launchpad and sales demo does, and what is required for solr contianer as well already. There are many ways to do it, either just using travis php, or run php container first, before orchestrating the whole setup in second phase.

[andrerom]

As removing the files depends on QA, I'll just deprecate it for now.

So smaller PR here ready for review @lserwatka @mnocon

[mnocon]

Looks ok for me, one doc nitpick 😛

[mnocon]

Is it ok to link to 0.8 here? This VCL still supports 4.0 and needs manual changes (for example: https://github.com/ezsystems/ezplatform-http-cache/blob/master/docs/varnish/vcl/varnish4.vcl#L268) and we won't be changing it in 0.8 branch I guess.

I'd rather link to a file that is tailored for 5.1.

[andrerom]

See updates here and in ezsystems/ezplatform-http-cache#77

[mnocon]

Nice, thanks!

[alongosz]

Needs JIRA issue? :)

[andrerom]

@mnocon Did you test the slightly new VCL?