New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EZP-24612: Switch CS to PSR-2 #1348
Conversation
Go home ezrobot, you're obsolete :-D |
@gggeek Actually, that was helpful 😉 . It showed wherever things need to be fixed manually. |
OK, let's try another round |
Why use it if phpcbf fixes much more issues? |
that could be an alternative, but the remaining issues here is in our opinion to strict, it is forcing multiline conditions to be placed on one line, often breaking the soft limit line length, and sometimes also the hard one potentially. |
fb41532
to
e5f5873
Compare
Used [PHP-CS-Fixer](http://cs.sensiolabs.org) with only `psr2` *level*.
Ping @bdunogier @yannickroger @glye @pspanja Note that @ezrobot is pretty long (no cache yet for php-cs-fixer on Jenkins) |
+1 with last bits fixed. |
Everything has passed now. Merging |
Fix EZP-24612: Switch CS to PSR-2
Goodbye ezcs, you were the pinnacle of readability... 😭 |
Used PHP-CS-Fixer with
symfony
level, but deactivating the following fixers:concat_without_spaces
(actually enforcesconcat_with_spaces
from contrib level)empty_return
phpdoc_params
spaces_cast