Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-24612: Switch CS to PSR-2 #1348

Merged
merged 7 commits into from Jul 22, 2015
Merged

Fix EZP-24612: Switch CS to PSR-2 #1348

merged 7 commits into from Jul 22, 2015

Conversation

lolautruche
Copy link
Contributor

Used PHP-CS-Fixer with symfony level, but deactivating the following fixers:

  • concat_without_spaces (actually enforces concat_with_spaces from contrib level)
  • empty_return
  • phpdoc_params
  • spaces_cast

@gggeek
Copy link
Contributor

gggeek commented Jul 20, 2015

Go home ezrobot, you're obsolete :-D
Either that, or some configs have to be changed...

@lolautruche
Copy link
Contributor Author

@gggeek Actually, that was helpful 😉 . It showed wherever things need to be fixed manually.

@lolautruche
Copy link
Contributor Author

OK, let's try another round

@orlangur
Copy link

Used PHP-CS-Fixer with only psr2 level.

Why use it if phpcbf fixes much more issues?

@andrerom
Copy link
Contributor

that could be an alternative, but the remaining issues here is in our opinion to strict, it is forcing multiline conditions to be placed on one line, often breaking the soft limit line length, and sometimes also the hard one potentially.

@lolautruche lolautruche changed the title Switch to PSR-2 Fix EZP-24612: Switch CS to PSR-2 Jul 21, 2015
@lolautruche
Copy link
Contributor Author

Ping @bdunogier @yannickroger @glye @pspanja

Note that @ezrobot is pretty long (no cache yet for php-cs-fixer on Jenkins)

@pspanja
Copy link
Contributor

pspanja commented Jul 21, 2015

+1 with last bits fixed.

@lolautruche
Copy link
Contributor Author

Everything has passed now. Merging

lolautruche added a commit that referenced this pull request Jul 22, 2015
Fix EZP-24612: Switch CS to PSR-2
@lolautruche lolautruche merged commit 3ab82f6 into master Jul 22, 2015
@lolautruche lolautruche deleted the psr2 branch July 22, 2015 07:38
@pspanja
Copy link
Contributor

pspanja commented Jul 22, 2015

Goodbye ezcs, you were the pinnacle of readability... 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants