Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] EZP-29659: As a v2 User I want support for InMemory SPI cache #2453

Closed
wants to merge 3 commits into from

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Sep 21, 2018

Question Answer
JIRA issue EZP-29659
New feature yes
Target version master
BC breaks no
Tests pass yes
Doc needed maybe on trouble shooting section, or places explaining caching

As a System Administrator & Developer I'd like SPI cache to re-introduce support for in-memory cache.

However unlike 1.x it must be:

  • limited to not eat up all available memory
  • time limited so data does not risk becoming stale

Thus allowing it to be used also on long running command line scripts without need to document special ways to run them.

As it it to be limited memory wise it should also be:

  • When hitting limits and in need of making space: prefer to use available space for non content cache (meta data) which is frequently needed by the system, and in-frequently changed

Brings cache lookups down to the following on clean install in combination with ezsystems/ezplatform-admin-ui#633 & #2444 compared to clean master/2.3-beta1:

  • Front: from 74 / 184 to 22 / 59 cache calls => 3x less cache calls
  • Admin Dashboard: from 478 / 1452 to 52 / 156 cache calls => 9x less cache calls
  • Admin Content structure: from 484 / 1421 to 70 / 204 cache calls => 7x less cache calls

This will especially benefit users on clusters where (Redis) cache server is on different host (latency).

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@ezrobot

This comment has been minimized.

@andrerom andrerom force-pushed the content_type_on_content branch 4 times, most recently from 91c61cd to 042481c Compare September 23, 2018 08:27
@andrerom andrerom changed the base branch from content_type_on_content to master September 24, 2018 07:53
@andrerom andrerom changed the title [WIP] EZP-29659: As a v2 User I want support for InMemory SPI cache EZP-29659: As a v2 User I want support for InMemory SPI cache Sep 24, 2018
@ezrobot

This comment has been minimized.

@andrerom
Copy link
Contributor Author

andrerom commented Sep 24, 2018

Passing ✅ (Travis passing on aeffe2e).

So calling for review here.

EDIT: Will look into how this can be done in external Bundle instead, and cleanup some of the concepts while at it.

@andrerom andrerom changed the title EZP-29659: As a v2 User I want support for InMemory SPI cache [POC] EZP-29659: As a v2 User I want support for InMemory SPI cache Oct 4, 2018
@andrerom
Copy link
Contributor Author

Closing, as we will take another direction on this one.

@andrerom andrerom closed this Oct 31, 2018
@andrerom andrerom deleted the in-memory-cache branch October 31, 2018 11:19
@andrerom andrerom restored the in-memory-cache branch March 5, 2019 09:11
@andrerom andrerom deleted the in-memory-cache branch March 5, 2019 09:56
@andrerom andrerom restored the in-memory-cache branch March 25, 2019 15:00
@andrerom andrerom deleted the in-memory-cache branch March 25, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants