Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReindexCommand.php #2479

Closed
wants to merge 1 commit into from
Closed

Conversation

RemySMILE
Copy link

Add user parameter.

Question Answer
JIRA issue EZP-XXXXX
Improvement yes
New feature yes
Target version master
BC breaks yes/no
Tests pass yes/no
Doc needed yes

Add --user=xx parameter.
Connect with this user to reporitory.

TODO:

  • Implement feature / fix a bug.
  • [ x ] Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • [ x ] Ask for Code Review.

Add user parameter.
@ezrobot
Copy link
Contributor

ezrobot commented Nov 16, 2018

Tool version : PHP CS Fixer 2.7.1 Sandy Pool by Fabien Potencier and Dariusz Ruminski
Command executed php-cs-fixer --dry-run -v fix
This Pull Request does not respect PSR-2 Coding Standards, please, see the suggested diff below:

diff --git a/eZ/Bundle/EzPublishCoreBundle/Command/ReindexCommand.php b/eZ/Bundle/EzPublishCoreBundle/Command/ReindexCommand.php
index 9d43bbb..f5167ba 100644
--- a/eZ/Bundle/EzPublishCoreBundle/Command/ReindexCommand.php
+++ b/eZ/Bundle/EzPublishCoreBundle/Command/ReindexCommand.php
@@ -158,7 +158,7 @@ EOT
             $user = $repository->getUserService()->loadUser($userID);
             $repository->setCurrentUser($user);
         }
-        
+
         $commit = !$input->getOption('no-commit');
         $iterationCount = $input->getOption('iteration-count');
         $this->siteaccess = $input->getOption('siteaccess');

@andrerom
Copy link
Contributor

andrerom commented Nov 16, 2018

Besides CS comment above I would suggest:

@kmadejski
Copy link
Member

@RemySMILE thank you for your contribution. I took what you did and applied @andrerom suggestions, therefore I'm closing this PR in favor of: #2485. Please fell free to review.

@kmadejski kmadejski closed this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants