EZP-30013: --env option not passed to parallel processes of ezplatform:reindex Command

[mateuszbieniek]

Question	Answer
JIRA issue	EZP-30013
Bug	yes
New feature	no
Target version	6.7, 6.13, 7.4
BC breaks	no
Tests pass	yes
Doc needed	no

[alongosz]

This starts to be a maintenance hell, we should consider some uniform handling of these.
But env is probably a special case anyway, so +1 with the following change:

[gggeek]

As a side note: when generating SF (sub)commands, I found out that it helps to also add the following snippet:

        if (!$kernel->isDebug()) {
            $subProcessArgs[] = '--no-debug';
        }

to propagate usage of the --no-debug flag (in case the user is on a Dev env but wants to save some ram and cpu)

[andrerom]

This starts to be a maintenance hell, we should consider some uniform handling of these.

@alongosz Fully agree, there is a followup to do here, one option:
In Sf 4 there is something for this afaik, so maybe backport this feature to symfony-tools repo and take advantage of it already. There is nothing in Symfony for this, the PR I had in mind was never merged. So we can add trait or abstract controller in kernel if we'd like to reuse this.

[andrerom]

@mateuszbieniek Could you also add the logic @gggeek mentioned?

[mateuszbieniek]

@andrerom I'm on it

[lserwatka]

Could you merge it up?

[kmadejski]

@lserwatka merged up in bbf4332 / 9f8c347 / d6c2968 / 4f484f6.

[gggeek]

Sorry for the late comment, and maybe I am missing something evident here, but it seems wrong for this command to access directly the spi layer bypassing the Repo services, as it introduces a strong tie to the DB schema... Is it due to the fact that there is currently no way to force the Repo services to execute db queries even when the Search is configured to use a separate system such as Solr?

[mateuszbieniek]

@gggeek it seems that your comment is out of the scope of this PR.
Maybe you could create a public ticket for it here: jira.ez.no?

[gggeek]

@mateuszbieniek done: https://jira.ez.no/browse/EZP-30558

[mateuszbieniek]

@gggeek thanks!