Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EZP-29418: Wrong Session Name after EZP-29390 #1377

Merged
merged 1 commit into from Jul 18, 2018
Merged

Fix EZP-29418: Wrong Session Name after EZP-29390 #1377

merged 1 commit into from Jul 18, 2018

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Jul 16, 2018 •
edited

Question Answer
JIRA issue EZP-29418
Bug yes
New feature no
Target version 2017.12

Regression from #1373
When a sessionName is set, it will generate a new one in the else if section.

@blankse blankse changed the base branch from master to 2017.12 July 16, 2018 09:31
@blankse blankse mentioned this pull request Jul 18, 2018
Merged
@blankse
Copy link
Contributor Author

blankse commented Jul 18, 2018

@kmadejski @andrerom Can you review it?

@andrerom andrerom merged commit dee1c5c into ezsystems:2017.12 Jul 18, 2018
@blankse blankse deleted the fix_session branch July 18, 2018 11:57
andrerom added a commit that referenced this pull request Jul 18, 2018
@andrerom
Fix CS from #1377
c17f617
@andrerom
Copy link
Contributor

Fixed CS in c17f617 and released as:

Thanks a lot @blankse ! 👍

@blankse
Copy link
Contributor Author

blankse commented Jul 18, 2018

Thank you @andrerom !

@emodric
Copy link
Collaborator

emodric commented Jul 18, 2018

Thanks @blankse ! This also fixes the notice I reported :)

@kmadejski
Copy link
Member

Thank you @blankse for this contribution! Well done! 👍

@pkamps pkamps mentioned this pull request Jul 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerom andrerom andrerom approved these changes

@kmadejski kmadejski kmadejski approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@blankse @andrerom @emodric @kmadejski