Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version 0.2.0 :-) #14

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

New version 0.2.0 :-) #14

wants to merge 16 commits into from

Conversation

schroeder
Copy link

Hi,

I have made a couple of changes to the ezxmlinstaller.
I am sorry, but I am just starting to use git, so the changes are not really good organized into separate commits.
If you have questions, please ask!

Greets
Dirk

@bdunogier
Copy link
Member

Hi Dirk, and thank you for the pull request.

One first remark: eZ XML Installer's version is currently 1.4.0 (released along with teamroom for eZ Publish Etna (4.7)). Due to support & maintenance, we do have to bump the version for every eZ Publish release even if there are no changes.

This doesn't invalidate the changes, but the version number changes aren't really required.

@schroeder
Copy link
Author

Hi Bertrand,

the version number in the source code and README file was 0.1.5, so I decided to count it up a bit. But the version number is the most uninteressting change in my pull request ;-)

@schroeder
Copy link
Author

BTW: I am currently working on a better and more detailed documentation, but as it is the documentation lacks in time.
And Artur told me that the teamroom will get a refresh, so I decided to pull the code changes asap to have it in the main code.
But the documentation will follow.

@bdunogier
Copy link
Member

Honestly, @schroeder, I intend to pull this in very soon. If you have time, it would really be nice if you could just change your version number references so that 1.4 is considered the current stable version.

Do not pay real attention to the version numbers in file headers, ezinfo, etc, they're automatically replaced by our build system (it won't hurt if you change them, but it will only be for raw git exports).

Cheers.

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants