ci: fix flashy tests #220
Closed
ci: fix flashy tests #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Pull Request resolved: facebook#220 This test was failing in CI because the expected output was not what was actually being logged. It was just a simple miss and not indicative of any other problem so this just adjusts the expected result. Test Plan: CI Differential Revision: D46232899 Reviewed By: smithscott fbshipit-source-id: 88910d4ea2dae25c521f246bb5c74d5bd3d3dfad
Scott8440
added a commit
to Scott8440/openbmc
that referenced
this pull request
May 26, 2023
Summary: Pull Request resolved: facebook#220 This test was failing in CI because the expected output was not what was actually being logged. It was just a simple miss and not indicative of any other problem so this just adjusts the expected result. Test Plan: CI Differential Revision: D46232899 Reviewed By: smithscott fbshipit-source-id: 116284fe69a282d9a77c1491acfe270a6af8ccc2
Scott8440
force-pushed
the
export-D46232899
branch
from
d4eea7c
to
223fd9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46232899 |
Scott8440
force-pushed
the
export-D46232899
branch
from
223fd9b
to
0057427
Compare
|
This pull request was exported from Phabricator. Differential Revision: D46232899 |
|
This pull request has been merged in 642eda5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This test was failing in CI because the expected output was not what was actually being logged. It was just a simple miss and not indicative of any other problem so this just adjusts the expected result.
Test Plan: CI
Differential Revision: D46232899
Reviewed By: smithscott