Prepare for SchemaDocument LSP Support #4668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
lsp-schema-text-sync
branch
from
aeb4e32
to
39e9182
Compare
tobias-tengler
commented
Apr 5, 2024
tobias-tengler
changed the title
captbaritone
reviewed
Apr 5, 2024
tobias-tengler
force-pushed
the
lsp-schema-text-sync
branch
from
39e9182
to
4cefb54
Compare
This was referenced Apr 8, 2024
|
@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
tobias-tengler
force-pushed
the
lsp-schema-text-sync
branch
from
4cefb54
to
92b94be
Compare
tobias-tengler
force-pushed
the
lsp-schema-text-sync
branch
from
92b94be
to
530fb41
Compare
|
@captbaritone is this blocked internally? Let me know if there's anything I can do and sorry for all of these PRs that probably don't fit what you're working on atm 😅 |
|
Hey! I've just been super busy and there are some internal crates which need to be updated to work with these changes. Still on my list, and (as always) I appreciate the pings for your changes. I do want to get them all in! |
|
@captbaritone ping 😅 |
|
@captbaritone merged this pull request in ed507de. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the necessary preparations to power LSP functionality inside
.graphqlfiles.