Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Setting Permissions of Created Files #2525

Merged
merged 8 commits into from
May 5, 2021
Merged

Improve Setting Permissions of Created Files #2525

merged 8 commits into from
May 5, 2021

Commits on May 5, 2021

  1. Add Tests Checking File Permissions of Created Files

    @felixhandte
    felixhandte committed May 5, 2021
    Configuration menu
    Copy the full SHA
    4e10ff1 View commit details
    Browse the repository at this point in the history

  2. Create Files with Desired Permissions; Avoid chmod(); Remove UTIL_chm… 

    …od()
    @felixhandte
    felixhandte committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b87f97b View commit details
    Browse the repository at this point in the history

  3. Don't Block Removing File on Being Able to Read It 

    `open()`'s mode bits are only applied to files that are created by the call.
If the output file already exists, but is not readable, the `fopen()` would
fail, preventing us from removing it, which would mean that the file would
not end up with the correct permission bits.

It's not clear to me why the `fopen()` is there at all. `UTIL_isRegularFile()`
should be sufficient, AFAICT.
    @felixhandte
    felixhandte committed May 5, 2021
    Configuration menu
    Copy the full SHA
    1fb10ba View commit details
    Browse the repository at this point in the history

  4. Attempt to Fix stat Format for BSDs

    @felixhandte
    felixhandte committed May 5, 2021
    Configuration menu
    Copy the full SHA
    018ed65 View commit details
    Browse the repository at this point in the history

  5. Fix Build for Windows

    @felixhandte
    felixhandte committed May 5, 2021
    Configuration menu
    Copy the full SHA
    45c4918 View commit details
    Browse the repository at this point in the history

  6. rm -f in playTests.sh

    @felixhandte
    felixhandte committed May 5, 2021
    Configuration menu
    Copy the full SHA
    bea1b2b View commit details
    Browse the repository at this point in the history

  7. Also Pass Mode Bits in on Windows 

    I think in some unix emulation environments on Windows, (cygwin?) mode bits
are somehow respected. So we might as well pass them in. Can't hurt.
    @felixhandte
    felixhandte committed May 5, 2021
    Configuration menu
    Copy the full SHA
    da61918 View commit details
    Browse the repository at this point in the history

  8. Attempt to Fix Windows Build Error

    @felixhandte
    felixhandte committed May 5, 2021
    Configuration menu
    Copy the full SHA
    4f9c6fd View commit details
    Browse the repository at this point in the history