Skip to content

Commit

Permalink
Revert "checksums.multi: make multi-checksum an instance of checksum"
Browse files Browse the repository at this point in the history 
This reverts commit fbeb409.
  • Loading branch information
@mrjbq7
mrjbq7 committed Aug 13, 2020
1 parent 995d717 commit 8eb78b9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion extra/checksums/multi/multi.factor
View file
Expand Up @@ -25,4 +25,4 @@ M: multi-state get-checksum
dup states>> [ get-checksum ] map [ >>results ] keep
] unless* nip ;

INSTANCE: multi-checksum checksum
INSTANCE: multi-checksum block-checksum

3 comments on commit 8eb78b9

@alex-ilin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrjbq7, why did you have to revert this?

@mrjbq7
Copy link
Member Author

@mrjbq7 mrjbq7 commented on 8eb78b9 Aug 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without it, it only uses the default implementation of checksum-bytes (M\ checksum checksum-bytes) which calls checksum-stream (M\ checksum checksum-stream) which calls... checksum-bytes which calls...

This caused the build machines to get stuck testing checksums.multi. Perhaps you had another fix in mind? If you want to submit a different PR, I'd merge it!

@alex-ilin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I'll have to work around that.

Please sign in to comment.