Arm64 mac #2877
Open
Arm64 mac #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Xcode/factorOSX/factor.xcodeproj/project.pbxproj # Xcode/factorOSX/factor.xcodeproj/xcshareddata/xcschemes/factor.xcscheme
|
Did you forget to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes I made while debugging ARM64.
In main-unix.cpp code added to test and display every combination of protection bits. Passes on Linux, fails on Mac.
In os-unix.cpp the guard pages are disabled, failure will occur later.
This can probably go into main as the os-unix.cpp would only be compiled for Mac. The test code in main-unix is commented out.