Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: feature(scap): allow custom tracepoints on ebpf probe #1375

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Molter73
Copy link
Contributor

@Molter73 Molter73 commented Oct 3, 2023

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area libscap

Does this PR require a change in the driver versions?

What this PR does / why we need it:

This change allows eBPF probes created with tracepoints other than the ones used by Falco to be directly attached and detached. This is useful for adopters that might want to go through the additional effort of attaching directly to the syscalls they care about, excluding sys_enter and sys_exit which could add extra computing effort, even for ignored syscalls. Because adopters need to go the extra mile to compile a probe from their own source code, I don't think a separate mechanism for controlling whether the custom tracepoints are attached or not is needed, simply finding such a tracepoint means we want it attached.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

This change allows eBPF probes created with tracepoints other than the
ones used by Falco to be directly attached and detached. This is useful
for adopters that might want to go through the additional effort of
attaching directly to the syscalls they care about, excluding sys_enter
and sys_exit which could add extra computing effort, even for ignored
syscalls. Because adopters need to go the extra mile to compile a probe
from their own source code, I don't think a separate mechanism for
controlling whether the custom tracepoints are attached or not is
needed, simply finding such a tracepoint means we want it attached.

Signed-off-by: Mauro Ezequiel Moltrasio <mmoltras@redhat.com>
@poiana
Copy link
Contributor

poiana commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Molter73

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Molter73
Copy link
Contributor Author

Molter73 commented Oct 3, 2023

I'll open an issue for discussing this in a minute, wanted to have the draft PR so I could point to it as a possible implementation that could work for our use case.

@incertum
Copy link
Contributor

Suggestions:

@incertum
Copy link
Contributor

incertum commented Dec 7, 2023

@gnosek made some great suggestions here #1527 (comment)

@poiana
Copy link
Contributor

poiana commented Mar 6, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@FedeDP
Copy link
Contributor

FedeDP commented Mar 6, 2024

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants