-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change CVE-2024-3094 to match liblzma contain instead of endswith #245
Conversation
Signed-off-by: Edgaras <edgaras@apsega.lt>
Welcome @apsega! It looks like this is your first PR to falcosecurity/rules 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me!
LGTM label has been added. Git tree hash: 56a2344a6ca08804aecca91738487a2421b8bc0d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/milestone falco-0.38-rules
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apsega, darryk10, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rules files suggestionsfalco-incubating_rules.yamlComparing Minor changes:
Patch changes:
|
What type of PR is this?
/kind bug
/area rules
/area maturity-incubating
What this PR does / why we need it:
Some of the docs in the wild of how to reproduce XZ vulnerability relies on patching
liblzma
and having the filename withpatch
suffix, for example -liblzma.so.5.6.1.patch
, thus this Falco rule doesn't pick this up. Changing rule to matchcontains
string resolves the issue.Some examples of who's using
liblzma.so.5.6.1.patch
name: