[Feature] Assign new colors for the products in the admin area

[dmitrychekalin]

https://fameandpartners.atlassian.net/browse/WEBSITE-204

Problem:
Ability to create ProductColorValues on admin ui

• associate product
• associate option_value (somehow? Create it?)

Implemented as a new form for the product colors page http://prnt.sc/att0yz. Colors (except already assigned colors for this product) are loading dynamically.

@tiagoamaro, is there a requirement to delete colors from a product?

• YES ,Tania wanted to delete colors in fame_admin too .

[namproctin]

This works for creating a new color , but we need to associate a newly created color to a dress in admin as well

[tiagoamaro]

This error was caused by a rack bug, introduced on versions prior to 1.6.1. Its opened file verification was considering parameters that weren't a file as a file, and it raised this error. The explanation for this issue can be found here rack/rack#814.

Updating Rack and QAing preprod is the better option for the bug introduced by this issue.

Update: updating rack will be impossible, since modern ActionPack depends on older Rack versions. I would vote on just changing the multipart_part_limit to a specified number, where this error won't happen.

Example: we now have 230 colors on the dress-color option value (Spree::OptionType.color.count). If we limit that Rack file limit to 300, that should be fine until Rails is updated to version 4.

Suggestion (though it's stupid using puts instead of logger, but it's default and it'll work on dev fine)

if Gem::Version.new(Rails::VERSION::STRING) < Gem::Version.new('4')
  Rack::Utils.multipart_part_limit = 300
else
  puts '------------------------------------------------------------------------------------------------------'
  puts 'Rails is on its 4 version! Upgrade Rack to its latest version to solve rack/rack#814, "Too many open files"'
  puts '------------------------------------------------------------------------------------------------------'
end

[tiagoamaro]

Slim tip: when you have small nested tags like this you can use two points to "inline nest" them

.col-md-3 : p : b
  SKU

[dmitrychekalin]

Cool tip, thanks a lot!

[namproctin]

some screenshots and test cases are needed

[tiagoamaro]

That's a very good point @namproctin. The Admin UI has been lacking tests from developer confidence that'll "simply work". As it grows, that assertion could be false.

[tiagoamaro]

Hmm, careful when upgrading major versions of other gems you're not actually using. Those could break behavior from other areas/specs. Was this upgrade intended?

[tiagoamaro]

👍 LGTM! 👍

There's a small comment on the Gemfile.lock on updating unwanted gems.

Just CI complaining, probably because of fixture database. Going to prepare one and commit here.

@namproctin any comments on this?

[namproctin]

making color deletion feature on fame_admin is wanted

[namproctin]

should be 'Create a new product-color association' OR 'Add new color to product'

[tiagoamaro]

@namproctin's right. This isn't a "New Color Creation" action. IMO, "Add new color to product" is fine.

[tiagoamaro]

@dmitrychekalin , freel free to

This now has a full CRUD on ProductColorValues =D