Skip to content

Commit

Permalink
Updated SlimerJS and Firefox
Browse files Browse the repository at this point in the history
Seems to fix #13 at least for the Ubuntu cases.
  • Loading branch information
thvitt committed Mar 19, 2018
1 parent 1f41014 commit 3ef0907
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pom.xml
Expand Up @@ -271,13 +271,13 @@
<artifactItem>
<groupId>net.faustedition</groupId>
<artifactId>slimerjs</artifactId>
<version>0.10.1</version>
<version>1.0.0-beta.1</version>
<type>zip</type>
</artifactItem>
<artifactItem>
<groupId>org.mozilla</groupId>
<artifactId>firefox</artifactId>
<version>45.4.0esr</version>
<version>57.0.4</version>
<classifier>${os.detected.classifier}</classifier>
<type>tar.bz2</type>
</artifactItem>
Expand Down Expand Up @@ -320,7 +320,7 @@
<!-- For PhantomJS: -->
<!-- <argument>-Dphantomjs.binary=${phantomjs.binary}</argument> -->
<!-- For SlimerJS instead: -->
<argument>-Dphantomjs.binary=${project.build.directory}/dependency/slimerjs-0.10.1/slimerjs</argument>
<argument>-Dphantomjs.binary=${project.build.directory}/dependency/slimerjs-1.0.0-beta.1/slimerjs</argument>
<argument>-Dfaust.diplo.allowedFailures=${faust.diplo.allowedFailures}</argument>
<argument>-Dfaust.diplo.server=${faust.diplo.server}</argument>
<argument>-Dfaust.diplo.port=${faust.diplo.port}</argument>
Expand Down
2 changes: 2 additions & 0 deletions src/main/java/net/faustedition/gen/DiplomaticConversion.java
Expand Up @@ -139,6 +139,8 @@ public boolean buildSVGs() {
resolvedSvgPath.toString());
if (debugPhantomJS)
arguments.add(1, "--debug=errors");
if (arguments.get(0).contains("slimerjs"))
arguments.add(1, "--headless");

final Optional<Path> imageLinkPath = getImageLinkPath();
if (imageLinkPath.isPresent()) {
Expand Down

0 comments on commit 3ef0907

Please sign in to comment.