Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#11 Allow generation of HTML without opening browser #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eugene-Kolesnikov
Copy link

Added the ability to output an embedded html code as a string as well as to write the html file to the filesystem without opening a browser.

write the html file to the filesystem without opening a browser.
@vidyap-xgboost
Copy link

I was looking for this! Hope this gets merged soon!

@fbdesignpro
Copy link
Owner

Hello @Eugene-Kolesnikov, thank you so much for your contribution! For the past few weeks I've either been buried in work, or otherwise unable to check back in. I should have slightly more time now, so I can finally pipe up here!

My original plan was to have more flexible outputs and this is right along those lines.

You mention generating "embedded HTML" but I'm guessing you are outputting the full HTML page (i.e. HTML, HEAD). I was approaching the problem as 2 components:

  1. Outputting without popping up the browser
  2. Generating HTML that can be embedded in an existing BODY tag (e.g. Jupyter notebook or other webpage)

"1" is pretty straightforward and is what you are doing. I was wondering if you or anyone needed "2" for purposes other than a notebook, because I would change the HTML generation to output something that is "contained" in something like a DIV of fixed size or something like that.

I hope that made sense :)

Either way, I will probably merge this into the next build pretty soon (I still don't have a lot of time on my hands but this will get better soon), as it seems to fulfill a need. :)

@anirbansaha96
Copy link

This is exactly a solution I was searching for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants