removed the integrity exception

[tessie]

Removed the integrity exception from fedoratagger.api.api.py

[ralphbean]

So, the reason we decided we could remove this except block is that we looked into it and found that the add_rating function protects itself against error already -- it will never raise an integrityerror in the way we were expecting it here.

https://github.com/fedora-infra/fedora-tagger/blob/develop/fedoratagger/lib/__init__.py#L89

I'm 👍 to the change, but I'll leave the PR open in case any other infra devs want to take a look.

[tessie]

Hi

So will it be considered as patch for opw

Regards
Tessy

On Fri, Nov 8, 2013 at 6:20 PM, Ralph Bean notifications@github.com wrote:

So, the reason we decided we could remove this except block is that we
looked into it and found that the add_rating function protects itself
against error already -- it will never raise an integrityerror in the way
we were expecting it here.

https://github.com/fedora-infra/fedora-tagger/blob/develop/fedoratagger/lib/__init__.py#L89

I'm [image: 👍] to the change, but I'll leave the PR open in case any
other infra devs want to take a look.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/127#issuecomment-28106324
.

[ralphbean]

So will it be considered as patch for opw

Oh, yes. Of course. :)

[pypingou]

I recognize myself in this code, I often have belt in suspenders :)

👍 for me

[ralphbean]

Cool -- I'll merge it in! Thanks @tessie, @pypingou!