Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render template of teams and meetings data from yaml file #236

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

subhangi2731
Copy link
Contributor

I created a separate YAML file where I have listed all the teams and their associated meeting names. Then I created a new function which has read the team yaml file and then returned a new html page with every data in it. Thus to send html content, I used the function "render_template" where the first argument of this function is the teams.html template file which I created in the template directory. Used @main.get annotation with teams URL to get all the teams data.

@subhangi2731
Copy link
Contributor Author

Screenshot from 2022-01-28 19-44-24

@subhangi2731 subhangi2731 force-pushed the meeting_teams branch 2 times, most recently from bc5069a to a0101fe Compare January 28, 2022 16:05
@subhangi2731
Copy link
Contributor Author

@darknao @t0xic0der please have a look to it and let me know if any corrections are needed

@subhangi2731 subhangi2731 force-pushed the meeting_teams branch 3 times, most recently from 03f2970 to 26bfdf7 Compare February 3, 2022 06:52
@subhangi2731
Copy link
Contributor Author

Screenshot from 2022-02-03 12-23-52
Screenshot from 2022-02-03 12-23-44
Screenshot from 2022-02-03 12-23-25

@subhangi2731
Copy link
Contributor Author

@t0xic0der @darknao please check and let me know how it looks

Copy link
Collaborator

@darknao darknao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me so long to review this...

For reference purpose: link to Marin design https://user-images.githubusercontent.com/799683/144504408-0031c0d5-684b-4e41-ba25-93942719489c.png

See if you can take a little step closer to this design when it comes to font choice, size, and color of the various elements in the team list.

src/mote/main.py Outdated Show resolved Hide resolved
src/mote/main.py Outdated Show resolved Hide resolved
src/mote/templates/teams.html Outdated Show resolved Hide resolved
src/mote/templates/teams.html Outdated Show resolved Hide resolved
src/mote/templates/teams.html Outdated Show resolved Hide resolved
src/mote/main.py Outdated Show resolved Hide resolved
src/mote/templates/teams.html Outdated Show resolved Hide resolved
@subhangi2731
Copy link
Contributor Author

@darknao thanks for the update. I will do the changes

@subhangi2731
Copy link
Contributor Author

@t0xic0der @darknao done all the changes. Please have a look and let me know

@subhangi2731 subhangi2731 force-pushed the meeting_teams branch 3 times, most recently from df23d74 to ecea364 Compare March 2, 2022 17:50
@subhangi2731 subhangi2731 force-pushed the meeting_teams branch 2 times, most recently from 99b4cda to a5af61d Compare March 3, 2022 13:46
@subhangi2731
Copy link
Contributor Author

@t0xic0der @darknao I have done all the changes here as told by @darknao. I also rebased the branch and all the conflicting files are resolved now. Please check and let me know if everything is okay and this is ready to be merged?

Copy link
Collaborator

@darknao darknao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that you have rebased your work, please remove requirements.txt and add all missing required libraries to pyproject.toml

mote/main.py Show resolved Hide resolved
mote/main.py Outdated Show resolved Hide resolved
mote/static/css3/fragment.css Outdated Show resolved Hide resolved
@subhangi2731
Copy link
Contributor Author

@darknao @t0xic0der I have done all the changes. Is this ready to be merged?

@darknao
Copy link
Collaborator

darknao commented Mar 6, 2022

Not yet.
All checks are failing and needs to be fixed.
poetry.lock needs to be updated to include PyYAML. You can use poetry lock --no-update for that.
Note that you should have used the poetry add PyYAML command in the first place instead of editing the pyproject.toml file by hand. This would have updated both files for you.

And the yaml import is missing from main.py.

@subhangi2731
Copy link
Contributor Author

@darknao @t0xic0der resolved and updated all the dependencies in poetry.lock file. The checks are passing now. Now is this ready to be merged?

Copy link
Collaborator

@darknao darknao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants