Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable gravatar fallback #148

Open
ralphbean opened this issue Aug 10, 2013 · 7 comments
Open

reenable gravatar fallback #148

ralphbean opened this issue Aug 10, 2013 · 7 comments
Labels

Comments

@ralphbean
Copy link
Contributor

It used to be that we would first check libravatar for an image, if that failed we'd fallback to gravatar, and if that failed we'd fall back to the fedora logo.

One week before flock, I broke that (commented it out) because I realised that using OpenID as the key for libravatar was way better than using USER@fedoraproject.org as the key.

That gravatar fallback code should probably be re-added. We'll have to still use http://USERNAME.id.fedoraproject.org for libravatar and USERNAME@fedoraproject.org for gravatar. Tricky, not impossible.

@hroncok
Copy link

hroncok commented Aug 29, 2013

Will look at that one and send PR.

@hroncok
Copy link

hroncok commented Aug 29, 2013

I've enabled gravatar support in hroncok@57040d5

But this code overwrites it

# TODO This next line is temporary and can be removed.  We do
# libravatar ourselves here by hand to avoid pyDNS issues on epel6.
# Once those are resolved we can use pylibravatar again.
return "https://seccdn.libravatar.org/avatar/%s?%s" % (hash, query)

Is there a way to know if this has failed and is serving default pic? Cause I don't think so :(

So this might only be possible to use once pyDNS thing is solved?

@ralphbean
Copy link
Contributor Author

See here under "default url for missing images" - http://wiki.libravatar.org/api/

We could:

  • Make a query to libravatar with ?d=404, and if the response is a 404, then we return the gravatar url.
  • or return the libravatar url with ?d=<GRAVATAR_URL> which we had earlier on, but was removed.

The trick we never quite got working was to "triple fallback", direct users to libravatar.. if the image isn't there, have libravatar send them to gravatar... if the image isn't there, have gravatar send them to https://badges.fedoraproject.org/static/img/badger_avatar.png

@ralphbean
Copy link
Contributor Author

FWIW, pyDNS finally got branched for el6, so python-pylibravatar is making its way through epel-test. https://apps.fedoraproject.org/packages/python-pylibravatar/overview/

@hroncok
Copy link

hroncok commented Aug 30, 2013

Change Stable karma to 1 and let me check it in virtual machine with CentOS :)

@ralphbean
Copy link
Contributor Author

--enablerepo=epel-test ? 💃

@hroncok
Copy link

hroncok commented Aug 30, 2013

Yes, if you can do this on a machine, where this runs. :)

@github-actions github-actions bot added the Stale label Apr 12, 2024
@abompard abompard added good first issue Good for new contributors and removed EasyFix labels Apr 17, 2024
@github-actions github-actions bot removed the Stale label Apr 18, 2024
@ryanlerch ryanlerch added the todo label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants