fix: SystemNavigator.pop respects PopScope(canPop: true)

[furaiev]

Status

READY

Breaking Changes

NO

Description

This PR fixes 1st page in the Flow SystemNavigator.pop for Android.
During migration from WillPopScope to PopScope (v.0.1.0) there was missed a bug that reproduces on Androids SystemNavigator.pop:

• push the Flow with only one page in the stack that contains PopScope(canPop: true)
• call SystemNavigator.pop
• the screen is empty (Flow is in the stack, but flow doesn't have pages)

Proposed fix:

• call _navigator?.pop(); to call onPopInvoked
• then call Navigator.of(context).maybePop() for real navigation as in previous version of the package

This fix doesn't look like ideal, but it works and I haven't find other way to call onPopInvoked.

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore
• 🧪 Testing

[felangel]

Can we add a test for this?

[felangel]

@furaiev can you share a minimal reproduction sample? I tried to reproduce but was not able using the example app by wrapping the first page in the onboarding flow with a PopScope and using the system back button on Android.

[furaiev]

@felangel you are correct. I can not reproduce this in example, it looks like something with my configuration. Will check, thank you!