Handle looseversion errors

femtopixel · May 31, 2019 · 1f1159f · 1f1159f
1 parent f5c7ee6
commit 1f1159f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/Makefile b/Makefile
@@ -1,4 +1,4 @@
-VERSION ?= 0.4.3
+VERSION ?= 0.4.4
 CACHE ?= --no-cache=1
 FULLVERSION ?= ${VERSION}
 archs ?= arm32v7 amd64 i386 arm64v8 arm32v6

diff --git a/github_release_notifier/__init__.py b/github_release_notifier/__init__.py
@@ -3,4 +3,4 @@
 """
 
 __all__ = ['parser', 'webhook', 'notifier']
-__version__ = '0.4.3'
+__version__ = '0.4.4'
diff --git a/github_release_notifier/notifier.py b/github_release_notifier/notifier.py
@@ -38,8 +38,11 @@ def run(file: str = __DEFAULT_FILE__) -> dict:
             for entry in parse(package):
                 try:
                     condition = version_compare(str(entry['version']), str(get_version(package))) > 0
-                except ValueError as e:
-                    condition = LooseVersion(str(entry['version'])) > LooseVersion(str(get_version(package)))
+                except e:
+                    try:
+                        condition = LooseVersion(str(entry['version'])) > LooseVersion(str(get_version(package)))
+                    except e:
+                        condition = False
                 if condition:
                     database = _get_database(file)
                     database[package] = entry['version']

diff --git a/github_release_notifier/parser.py b/github_release_notifier/parser.py
@@ -26,9 +26,9 @@ def parse(package: str) -> List[dict]:
         if 'content' in item and item['content'][0] is not None and 'value' in item['content'][0]:
             current_dict['content'] = item['content'][0]['value']
         if (
-                'media_thumbnail' in item and
-                item['media_thumbnail'][0] is not None
-                and 'url' in item['media_thumbnail'][0]
+            'media_thumbnail' in item and
+            item['media_thumbnail'][0] is not None
+            and 'url' in item['media_thumbnail'][0]
         ):
             current_dict['media'] = item['media_thumbnail'][0]['url']
         entries.append(current_dict)