Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support README, LICENSE and CHANGES to be specified in the cfg #2286

Merged
merged 1 commit into from May 4, 2024

Conversation

robertoostenveld
Copy link
Contributor

This fixes #2084 as for cfg.README it now includes the default template from the starter kit.

@robertoostenveld
Copy link
Contributor Author

I also reordered the MATLAB help a little bit.

@Remi-Gau what do you think of it like this?

Copy link

github-actions bot commented May 4, 2024

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_issue1196, test_issue2235, test_data2bids

When inside the DCCN, please also consider testing: test_pull2043, test_issue1196, test_data2bids, test_issue1905

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

Copy link

github-actions bot commented May 4, 2024

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_issue1196, test_issue2235, test_data2bids

When inside the DCCN, please also consider testing: test_issue1196, test_data2bids, test_pull2043, test_issue1905

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

Copy link

github-actions bot commented May 4, 2024

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_data2bids, test_issue2235, test_issue1196

When inside the DCCN, please also consider testing: test_data2bids, test_pull2043, test_issue1905, test_issue1196

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

@robertoostenveld
Copy link
Contributor Author

This is following sccn/EEG-BIDS#143

@robertoostenveld robertoostenveld merged commit 129d5dc into fieldtrip:master May 4, 2024
2 checks passed
@robertoostenveld robertoostenveld deleted the issue2084 branch May 4, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default readme in BIDS dataset after conversion
1 participant