Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option value for interplimits to be sensors, rather than electrodes #2388

Merged
merged 2 commits into from Feb 8, 2024

Conversation

schoffelen
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Feb 8, 2024

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_tutorial_eventrelatedaveraging, test_bug3345, test_ft_plot_topo, inspect_pull1955, test_issue1238, test_ft_topoplotER, test_bug272, test_bug1607, test_bug2031, test_example_combineplanar_pipelineorder, test_issue1721, test_bug255, test_bug2086, test_issue714, test_shared_virtual_channels, test_tutorial_clusterpermutationfreq, test_pull2105, inspect_pull1946, test_tutorial_coherence, test_tutorial_eventrelatedstatistics, test_tutorial_plotting_old, inspect_bug2588, test_tutorial_plotting, test_pull810, inspect_pull1970, test_issue1568, test_bug3359, test_tutorial_clusterpermutationtimelock, test_bug2059

When inside the DCCN, please also consider testing: test_bug843, test_ft_megplanar, test_bug182, test_issue1238, test_bug2316, test_ft_topoplotER, test_bug1607, test_bug255, test_bug941, test_bug2086, test_bug1243, test_bug2485, test_bug2559, inspect_bug3033, test_bug1911, test_bug2354, test_pull810, test_bug3359, test_bug2473, test_bug2059, test_pull2099, test_bug1351, test_bug2315, test_bug1242, test_bug1800

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

Copy link

github-actions bot commented Feb 8, 2024

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_tutorial_eventrelatedaveraging, test_bug2059, test_bug2086, test_tutorial_clusterpermutationtimelock, test_bug3359, test_tutorial_plotting_old, test_pull810, inspect_pull1970, test_tutorial_plotting, test_pull2105, inspect_pull1955, test_tutorial_coherence, test_bug272, inspect_pull1946, test_tutorial_eventrelatedstatistics, test_shared_virtual_channels, test_bug2031, test_tutorial_clusterpermutationfreq, test_example_combineplanar_pipelineorder, test_issue714, test_issue1238, test_issue1568, test_bug255, test_ft_plot_topo, inspect_bug2588, test_bug1607, test_ft_topoplotER, test_issue1721, test_bug3345

When inside the DCCN, please also consider testing: test_bug1243, test_bug2059, test_bug2086, test_bug3359, test_bug2315, test_bug1911, test_bug2559, test_pull810, test_bug1242, test_bug1351, test_bug2473, test_ft_megplanar, test_bug2316, test_bug1800, inspect_bug3033, test_bug941, test_issue1238, test_bug843, test_bug2354, test_pull2099, test_bug255, test_bug2485, test_bug182, test_bug1607, test_ft_topoplotER

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

@schoffelen
Copy link
Contributor Author

I ran a 'bloemlezing' of the above suggested test functions, and they seem to not dislike the current PR.

@schoffelen schoffelen merged commit c2ff193 into fieldtrip:master Feb 8, 2024
2 checks passed
@schoffelen schoffelen deleted the interplim branch February 8, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant