Add API to look up users by provider user ID. #388
Conversation
nrsim
force-pushed
the
lookup-by-provider
branch
2 times, most recently
from
1b2c84f
to
e155a0a
Compare
nrsim
force-pushed
the
lookup-by-provider
branch
from
e155a0a
to
d256436
Compare
| @@ -308,6 +309,28 @@ def get_user_by_phone_number(phone_number, app=None): | |||
| response = user_manager.get_user(phone_number=phone_number) | |||
| return UserRecord(response) | |||
|
|
|||
| def get_user_by_provider_user_id(provider_id, provider_uid, app=None): | |||
There was a problem hiding this comment.
naming: get_user_by_provider_uid. (A recent change; sorry. :( )
| 'federated_user_id' : [{ | ||
| 'provider_id': _auth_utils.validate_provider_id(key['provider_id']), | ||
| 'raw_id': _auth_utils.validate_provider_id(key['provider_uid'])}] | ||
| } |
There was a problem hiding this comment.
Optional:
elif 'provider_id' in kwargs:
raise ValueError('provider_uid keyword argument must be supplied when setting provider_id argument')
elif 'provider_uid' in kwargs:
raise ValueError('provider_id keyword argument must be supplied when setting provider_uid argument')Alternatively, change the elif condition on 471 to be 'or' instead of 'and'. Then, let kwargs.pop throw a KeyError if one of them is missing. You won't get as nice of an error message though, so you may want to catch-and-rethrow at which point, you might be better off with the elif's.
| 'provider_id': provider_id, 'provider_uid': provider_uid | ||
| }, 'provider_user_id' | ||
| payload = { | ||
| 'federated_user_id' : [{ |
There was a problem hiding this comment.
Double check the spelling in the json payload. Normally, the json part needs to be camelCase. (i.e. like 470). But maybe the backend accepts both?
| password_hash=b'password', password_salt=b'NaCl', custom_claims={'admin': True}, | ||
| email_verified=True, | ||
| disabled=False, | ||
| provider_data=[auth.UserProvider(uid='test', provider_id='google.com')]) |
There was a problem hiding this comment.
Same comment as before: uid=test might cause this to fail if the test doesn't get properly cleaned up.
| phone_number=phone, | ||
| display_name='Random User', | ||
| photo_url='https://example.com/photo.png', | ||
| user_metadata=auth.UserMetadata(100, 150), |
There was a problem hiding this comment.
I couldn't figure out what 100,150 were without looking up UserMetadata. Named parameters would make this more obvious, i.e.
auth.UserMetadata(creation_timestamp=100, last_sign_in_timestamp=150)
Optional.
No description provided.