space infront of command leads to missing in history

[danielb2]

fish, version 3.1.0
Darwin zoro.local 18.2.0 Darwin Kernel Version 18.2.0 (Mojave)
iTerm2
tmux
TERM: screen-256color

Steps to reproduce:

1. type any command after putting a space infront, and hit enter

expected:
the command should run and it should appear in history

result:
The command runs, but hitting up arrow and it's missing, and it's missing from history

See:

[zanchey]

It's not a bug, it's a feature!

From https://fishshell.com/docs/current/#history-search:

Prefixing the commandline with a space will prevent the entire line from being stored in the history.

See also #615. We do get a lot of questions about this, it might be worth adding to the FAQ.

[danielb2]

funny, I even read that part of the docs and I missed it.I thought I had read it being a feature before. I checked other shells, and then I thought it's unintuitive because it's not expected. I had put a space in by accident.

[zanchey]

Yeah. I think it would be fair to describe it as polarising. Since #4327 got merged it's been harder to trip over, though.