Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completions busted for nested subcommands #913

Closed
ridiculousfish opened this issue Jul 17, 2013 · 2 comments
Closed

Completions busted for nested subcommands #913

ridiculousfish opened this issue Jul 17, 2013 · 2 comments
Assignees
@ridiculousfish
Milestone
fish 2.1.0

Comments

@ridiculousfish
Copy link
Member

echo (echo (echo fil<tab>

This doesn't work properly. The issue is that parse_util_locate_cmdsubst returns the outermost command substitution containing the cursor, not the innermost one.
@ghost ghost assigned ridiculousfish Jul 17, 2013
@ridiculousfish
Copy link
Member Author

Scary fix to make this behavior change, but it seems to work and all tests pass. Here we go.

@ridiculousfish
Copy link
Member Author

Fixed as 1511de6

haarts pushed a commit to haarts/fish-shell that referenced this issue Nov 1, 2013
@ridiculousfish
Make parse_util_locate_cmdsubst return the innermost command substitu…
1511de6 
…tion instead of the outermost.

Fixes fish-shell#913
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ridiculousfish ridiculousfish

Labels
None yet
Projects
None yet
Milestone
fish 2.1.0
Development

No branches or pull requests
1 participant
@ridiculousfish