Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react and react-dom peer dependencies to only allow >=18 #1079

Merged
merged 1 commit into from Mar 15, 2024

Conversation

grumd
Copy link
Contributor

@grumd grumd commented Mar 7, 2024

This will prevent users from installing the latest version of react-toastify if they're using an unsupported version of React.
I reckon this is the better option vs just getting "useSyncExternalStore is not a function" after installation.

Copy link
Owner

@fkhadra fkhadra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@coveralls
Copy link

Coverage Status

coverage: 89.106%. remained the same
when pulling 2ae7b24 on grumd:patch-1
into aea0bd9 on fkhadra:main.

@fkhadra fkhadra merged commit a4be2e3 into fkhadra:main Mar 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants