[JitBackend] Miscellaneous improvements to Jit infra #1124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lifetime This significantly simplifies node lifetime management, with one documented caveat -- `Use::user()` returns a `Node&` instead of `NodePtr`, and it also stores the data as `Node&` under the hood.
…ng results When evaluator decides whether to keep the result of a node, use the number of users instead of the raw shared_ptr refcount (which is overly conservative and breaks the soft abstraction of `NodePtr`).
This is often useful in graph transformation/analysis. The downcast mechanism also tries to keep the soft abstraction of `NodePtr`, `BinaryNodePtr`, etc (without leaking `std::shared_ptr` to users).
…n subgraph bounding box
facebook-github-bot
added
CLA Signed
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@StrongerXi has updated the pull request. You must reimport the pull request before landing. |
|
@StrongerXi has updated the pull request. You must reimport the pull request before landing. |
|
@StrongerXi has updated the pull request. You must reimport the pull request before landing. |
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jacobkahn merged this pull request in d49bef5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few changes to the Jit infra, mainly addressing 2 things:
Node.Test Plan (required)
Some unit tests are updated.
Some changes rely on existing test.
The
GraphVizPrinteris tested manually because I can't think of a good way to automate its testing.