Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocks are always iterable #57

Open
christophe-riolo opened this issue Aug 16, 2021 · 1 comment
Open

Mocks are always iterable #57

christophe-riolo opened this issue Aug 16, 2021 · 1 comment
Labels
enhancement

Comments

@christophe-riolo
Copy link
Contributor

In the pas there has been two issue about iterating on the mock:
has207/flexmock#11
has207/flexmock#74

Following those issues the mocks are always iterable, even when the mocked class is not. It would be better to not add iterablility to all mocks and only when required.
@christophe-riolo christophe-riolo mentioned this issue Aug 16, 2021
Merged
@ollipa
Copy link
Member

ollipa commented Aug 16, 2021

I tried the examples in those issues but none of them use the the yield self functionality. The line is here:

flexmock/src/flexmock/api.py

Line 92 in 3edc739

yield self

Maybe that fix affected just Python2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christophe-riolo @ollipa