Improve test coverage #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ollipa
force-pushed
the
task/improve-test-coverage
branch
from
ef48be0
to
eff5729
Compare
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 94.81% 97.00% +2.19%
==========================================
Files 4 4
Lines 771 769 -2
==========================================
+ Hits 731 746 +15
+ Misses 40 23 -17
Continue to review full report at Codecov.
|
ollipa
force-pushed
the
task/improve-test-coverage
branch
from
6db8d48
to
dbafadf
Compare
christophe-riolo
approved these changes
Aug 16, 2021
ollipa
force-pushed
the
task/improve-test-coverage
branch
from
d9e9e58
to
e838db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some tests to cover some cases that were not tested before. There are still a few lines that are not covered by tests.
Related to #12.