Add warning to docs about new_instances method #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 833 833
=========================================
Hits 833 833 Continue to review full report at Codecov.
|
ollipa
force-pushed
the
docs/new-instances
branch
from
2b17f80
to
48bc37c
Compare
christophe-riolo
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we dropped Python 2 support,
new_instancesmethod can't be used in CPython without hitting the bug described in issue #16. The bug doesn't seem to affect PyPy.I added a warning about the usage of
new_instancesmethod in docs:Before we remove or deprecate this method, I think we should first think about some alternative way to fake new instances.