-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch pytest integration to hook #153
Conversation
Thank you for the fix! The tests seem to fail for Pytest 5 but I think we should drop support for Pytest 5 in the next release along with Python 3.7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and test suite passes! Can you update the CHANGELOG.md?
The linting should pass after you add docstring to the new pytest plugin file.
I made a PR to drop support for Python 3.7 and Pytest 5.x (#154). Feel free to rebase your changes onto that.
It seems that pytest yanked version 8.1.0 so anyone testing this branch should install pytest 8.1.0 explicitly.
Sphinx v7 dropped setuptools support and we still use it.
ea8527c
to
315c0ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 5 +1
Lines 834 832 -2
=========================================
- Hits 834 832 -2 ☔ View full report in Codecov by Sentry. |
Switch the pytest integration to the hook instead of wrapping the runner manually. Fixes flexmock#152 Signed-off-by: Matej Focko <mfocko@redhat.com>
8.1.1 at the time Signed-off-by: Matej Focko <mfocko@redhat.com>
When running Copr (RPM) build and Testing Farm, download the latest version of the specfile from the Fedora downstream rather than using an outdated specfile that is present in the repository. Also update the config to match the latest state of the Packit Service. Signed-off-by: Matej Focko <mfocko@redhat.com>
315c0ba
to
ba2843a
Compare
Sorry about the trouble with the pylint, I'm getting kinda inconsistent results with the |
I think it is just because you are using newer Python version locally. The CI uses the minimum supported Python version. Thank your work on this. I'll merge this PR soon and create a new release. |
Switch the pytest integration to the hook instead of wrapping the runner manually.
Fixes #152
TODO: