Not to log class name #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the log message contains the class name: 2021-12-19 22:59:31,787 ERROR [main] org.fluentd.logger.sender.RawSocketSender java.net.ConnectException: Connection refused (Connection refused) Since log frameworks usually have a way to log class name without the need to include it in the log message, the class name should be removed. The following text shows a sample log mesage after this change: 2021-12-19 22:56:58,842 ERROR [main] flush failed java.net.ConnectException: Connection refused (Connection refused) Signed-off-by: Jingguo Yao <yaojingguo@gmail.com>
yaojingguo
force-pushed
the
improve-logging
branch
from
89bb1d2
to
4b5b865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, the log message contains the class name:
2021-12-19 22:59:31,787 ERROR [main] org.fluentd.logger.sender.RawSocketSender
java.net.ConnectException: Connection refused (Connection refused)
Since log frameworks usually have a way to log class name without the
need to include it in the log message, the class name should be removed.
The following text shows a sample log mesage after this change:
2021-12-19 22:56:58,842 ERROR [main] flush failed
java.net.ConnectException: Connection refused (Connection refused)