-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] update version-lock file location #52842
Merged
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@parlough @eyebrowsoffire kind reminder. |
eyebrowsoffire
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this slipped through the cracks. LGTM!
parlough
approved these changes
Jun 4, 2024
parlough
added
the
autosubmit
Merge PR when tree becomes green via auto submit App
label
Jun 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 4, 2024
…149692) flutter/engine@fe00f02...3dd4015 2024-06-04 jonahwilliams@google.com [Impeller] tighten fast gradient condition. (flutter/engine#53195) 2024-06-04 reidbaker@google.com java fail on format missing (flutter/engine#53176) 2024-06-04 emmanuelferdman@gmail.com [web] update version-lock file location (flutter/engine#52842) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 5, 2024
…lutter#149692) flutter/engine@fe00f02...3dd4015 2024-06-04 jonahwilliams@google.com [Impeller] tighten fast gradient condition. (flutter/engine#53195) 2024-06-04 reidbaker@google.com java fail on format missing (flutter/engine#53176) 2024-06-04 emmanuelferdman@gmail.com [web] update version-lock file location (flutter/engine#52842) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
platform-web
Code specifically for the web engine
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #47573 renamed the version-lock file from
browser_lock.yaml
topackage_lock.yaml
. This PR adjusts sources to changes.Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.