Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] update version-lock file location #52842

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

emmanuel-ferdman
Copy link
Contributor

PR #47573 renamed the version-lock file from browser_lock.yaml to package_lock.yaml. This PR adjusts sources to changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@github-actions github-actions bot added the platform-web Code specifically for the web engine label May 15, 2024
@emmanuel-ferdman
Copy link
Contributor Author

emmanuel-ferdman commented Jun 4, 2024

@parlough @eyebrowsoffire kind reminder.

Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this slipped through the cracks. LGTM!

@parlough parlough added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 4, 2024
@auto-submit auto-submit bot merged commit aa66426 into flutter:main Jun 4, 2024
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 4, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 4, 2024
…149692)

flutter/engine@fe00f02...3dd4015

2024-06-04 jonahwilliams@google.com [Impeller] tighten fast gradient condition. (flutter/engine#53195)
2024-06-04 reidbaker@google.com java fail on format missing (flutter/engine#53176)
2024-06-04 emmanuelferdman@gmail.com [web] update version-lock file location (flutter/engine#52842)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 5, 2024
…lutter#149692)

flutter/engine@fe00f02...3dd4015

2024-06-04 jonahwilliams@google.com [Impeller] tighten fast gradient condition. (flutter/engine#53195)
2024-06-04 reidbaker@google.com java fail on format missing (flutter/engine#53176)
2024-06-04 emmanuelferdman@gmail.com [web] update version-lock file location (flutter/engine#52842)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
3 participants