-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Skia specific TUs. #52855
Rename Skia specific TUs. #52855
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
The CI failures are real. Taking a look at patching those up. |
Totally forgot about this. On it. |
8da42e9
to
4d2bb56
Compare
auto label is removed for flutter/engine/52855, due to - The status or check suite Mac mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
3012457
to
327e62f
Compare
…149068) flutter/engine@f693fdd...e020713 2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ef8ed68a8d4 to 641d61332238 (1 revision) (flutter/engine#53029) 2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 10459d97152a to 0b7d656b9c03 (3 revisions) (flutter/engine#53028) 2024-05-24 flar@google.com Reland "DisplayListBuilder internal reorganization with better rendering op overlap detection" (52646) (flutter/engine#53002) 2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 137a4ea4e033 to 10459d97152a (3 revisions) (flutter/engine#53027) 2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from d252bca326a6 to 137a4ea4e033 (1 revision) (flutter/engine#53026) 2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 97783ac3000d to d252bca326a6 (2 revisions) (flutter/engine#53025) 2024-05-24 chinmaygarde@google.com Rename Skia specific TUs. (flutter/engine#52855) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#149068) flutter/engine@f693fdd...e020713 2024-05-24 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ef8ed68a8d4 to 641d61332238 (1 revision) (flutter/engine#53029) 2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 10459d97152a to 0b7d656b9c03 (3 revisions) (flutter/engine#53028) 2024-05-24 flar@google.com Reland "DisplayListBuilder internal reorganization with better rendering op overlap detection" (52646) (flutter/engine#53002) 2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 137a4ea4e033 to 10459d97152a (3 revisions) (flutter/engine#53027) 2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from d252bca326a6 to 137a4ea4e033 (1 revision) (flutter/engine#53026) 2024-05-24 skia-flutter-autoroll@skia.org Roll Skia from 97783ac3000d to d252bca326a6 (2 revisions) (flutter/engine#53025) 2024-05-24 chinmaygarde@google.com Rename Skia specific TUs. (flutter/engine#52855) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Fixes flutter/flutter#148235