Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seemingly orphaned type IntlLocaleLike in icu-messageformat-parser #4413

Closed
Renegade334 opened this issue May 6, 2024 · 0 comments · Fixed by #4418
Closed

Seemingly orphaned type IntlLocaleLike in icu-messageformat-parser #4413

Renegade334 opened this issue May 6, 2024 · 0 comments · Fixed by #4418

Comments

@Renegade334
Copy link
Contributor

#3763 introduced a new type export in icu-messageformat-parser/types.ts:

export type IntlLocaleLike = {
  readonly hourCycle?: Intl.LocaleHourCycleKey
  readonly hourCycles?: Array<Intl.LocaleHourCycleKey>
}

It isn't referred to by any other code in that PR, nor anywhere else in the repo, and doesn't seem to be used in any other GitHub repo based on a quick search. Does it serve a purpose?

I only ask because there is a proposal to refactor Intl.Locale in the TypeScript library which would break this type declaration, so wondered if it would be easier to pre-emptively remove it entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant